[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pxa2xx: Auto-assign name for i2c bus in i2c_ini
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] pxa2xx: Auto-assign name for i2c bus in i2c_init_bus. |
Date: |
Mon, 17 Oct 2016 17:15:11 +0100 |
On 13 October 2016 at 10:44, Vijay Kumar B <address@hidden> wrote:
> If a name is provided, the same name is assigned to both the I2C
> controllers. Leaving it NULL, causes names to be automatically
> assigned with an ID suffix, giving unique names to each
> controller. This helps us to uniquely identify each controller in the
> device tree, for example when adding an I2C device.
>
> Signed-off-by: Vijay Kumar B. <address@hidden>
> Reviewed-by: Deepak S. <address@hidden>
> ---
> hw/arm/pxa2xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c
> index 0241e07..9898287 100644
> --- a/hw/arm/pxa2xx.c
> +++ b/hw/arm/pxa2xx.c
> @@ -1505,7 +1505,7 @@ static void pxa2xx_i2c_initfn(Object *obj)
> PXA2xxI2CState *s = PXA2XX_I2C(obj);
> SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
>
> - s->bus = i2c_init_bus(dev, "i2c");
> + s->bus = i2c_init_bus(dev, NULL);
>
> memory_region_init_io(&s->iomem, obj, &pxa2xx_i2c_ops, s,
> "pxa2xx-i2c", s->region_size);
Applied to target-arm.next, thanks.
-- PMM