[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs |
Date: |
Tue, 18 Oct 2016 12:40:02 +1100 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Tue, Oct 18, 2016 at 12:07:20PM +1100, Alexey Kardashevskiy wrote:
> Ping, anyone?
>
> I rather expected floods of mails on such a controversial topic :)
I think it's the reverse of the bike-shed problem. Hardly anyone
feels qualified to comment on it.
It looks ok to me, but I just don't know if there are other subtle
dependencies on the size of the cpumask buried in the code.
Oh well, let's say:
Reviewed-by: David Gibson <address@hidden>
and find any problems as they arise.
Not sure who we need to convince to take this into their tree though.
>
>
> On 11/10/16 09:19, Alexey Kardashevskiy wrote:
> > Ping, anyone?
> >
> >
> > On 04/10/16 11:33, Alexey Kardashevskiy wrote:
> >> From: Greg Kurz <address@hidden>
> >>
> >> Some systems can already provide more than 255 hardware threads.
> >>
> >> Bumping the QEMU limit to 1024 seems reasonable:
> >> - it has no visible overhead in top;
> >> - the limit itself has no effect on hot paths.
> >>
> >> Signed-off-by: Greg Kurz <address@hidden>
> >> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> >> ---
> >> include/sysemu/sysemu.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> >> index ef2c50b..2ec0bd8 100644
> >> --- a/include/sysemu/sysemu.h
> >> +++ b/include/sysemu/sysemu.h
> >> @@ -173,7 +173,7 @@ extern int mem_prealloc;
> >> *
> >> * Note that cpu->get_arch_id() may be larger than MAX_CPUMASK_BITS.
> >> */
> >> -#define MAX_CPUMASK_BITS 255
> >> +#define MAX_CPUMASK_BITS 1024
> >>
> >> #define MAX_OPTION_ROMS 16
> >> typedef struct QEMUOptionRom {
> >>
> >
> >
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs, Alexey Kardashevskiy, 2016/10/03
- Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs, Alexey Kardashevskiy, 2016/10/10
- Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs, Alexey Kardashevskiy, 2016/10/17
- Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs,
David Gibson <=
- Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs, Igor Mammedov, 2016/10/18
- Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs, Greg Kurz, 2016/10/18
- Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs, Alexey Kardashevskiy, 2016/10/18
- Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs, Igor Mammedov, 2016/10/19
- Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs, Alexey Kardashevskiy, 2016/10/23
- Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs, Igor Mammedov, 2016/10/24