[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] tests/test-vmstate.c: prove VMStateField.st

From: Halil Pasic
Subject: Re: [Qemu-devel] [PATCH 2/4] tests/test-vmstate.c: prove VMStateField.start broken
Date: Tue, 18 Oct 2016 15:43:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 10/18/2016 03:27 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (address@hidden) wrote:
>> > The handling of VMStateField.start is currently quite broken if
>> > VMS_ALLOC is present (that is for VMSTATE_VBUFFER_ALLOC_UINT32) but
>> > fortunately also quite underutilized -- nobody is using .start != 0.
>> > 
>> > Let's prove with this patch that it's really broken (as a first
>> > step towards fixing things up).
> You can't play this trick - patch series have to work and pass
> tests after each test, otherwise it messes up people in the future
> trying to do a git bisect.
> Dave

I think I understand the motivation. Does that mean
you are not supposed to expose a bug via a test? I might
be able to demonstrate that something is wrong but unable
to fix the problem myself (time constraints).

How was I supposed to do this?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]