[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 08/10] vmxnet3: fix reference leak issue
From: |
Dmitry Fleytman |
Subject: |
Re: [Qemu-devel] [PATCH v4 08/10] vmxnet3: fix reference leak issue |
Date: |
Wed, 19 Oct 2016 09:51:00 +0300 |
Reviewed-by: Dmitry Fleytman <address@hidden>
> On 19 Oct 2016, at 09:47 AM, Cao jin <address@hidden> wrote:
>
> On migration target, msix_vector_use() will be called in vmxnet3_post_load()
> in second time, without a matching second call to msi_vector_unuse(),
> which results in vector reference leak.
>
> CC: Dmitry Fleytman <address@hidden>
> CC: Jason Wang <address@hidden>
> CC: Markus Armbruster <address@hidden>
> Signed-off-by: Cao jin <address@hidden>
> ---
> hw/net/vmxnet3.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 7d44af1..a9854e4 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -2551,21 +2551,11 @@ static void vmxnet3_put_rxq_descr(QEMUFile *f, void
> *pv, size_t size)
> static int vmxnet3_post_load(void *opaque, int version_id)
> {
> VMXNET3State *s = opaque;
> - PCIDevice *d = PCI_DEVICE(s);
>
> net_tx_pkt_init(&s->tx_pkt, PCI_DEVICE(s),
> s->max_tx_frags, s->peer_has_vhdr);
> net_rx_pkt_init(&s->rx_pkt, s->peer_has_vhdr);
>
> - if (s->msix_used) {
> - if (!vmxnet3_use_msix_vectors(s, VMXNET3_MAX_INTRS)) {
> - VMW_WRPRN("Failed to re-use MSI-X vectors");
> - msix_uninit(d, &s->msix_bar, &s->msix_bar);
> - s->msix_used = false;
> - return -1;
> - }
> - }
> -
> vmxnet3_validate_queues(s);
> vmxnet3_validate_interrupts(s);
>
> --
> 2.1.0
>
>
>
- [Qemu-devel] [PATCH v4 00/10] Convert msix_init() to error, Cao jin, 2016/10/19
- [Qemu-devel] [PATCH v4 01/10] msix: Follow CODING_STYLE, Cao jin, 2016/10/19
- [Qemu-devel] [PATCH v4 08/10] vmxnet3: fix reference leak issue, Cao jin, 2016/10/19
- Re: [Qemu-devel] [PATCH v4 08/10] vmxnet3: fix reference leak issue,
Dmitry Fleytman <=
- [Qemu-devel] [PATCH v4 02/10] hcd-xhci: check & correct param before using it, Cao jin, 2016/10/19
- [Qemu-devel] [PATCH v4 07/10] megasas: undo the overwrites of msi user configuration, Cao jin, 2016/10/19
- [Qemu-devel] [PATCH v4 03/10] pci: Convert msix_init() to Error and fix callers to check it, Cao jin, 2016/10/19
- [Qemu-devel] [PATCH v4 04/10] megasas: change behaviour of msix switch, Cao jin, 2016/10/19
- [Qemu-devel] [PATCH v4 05/10] hcd-xhci: change behaviour of msix switch, Cao jin, 2016/10/19
- [Qemu-devel] [PATCH v4 06/10] megasas: remove unnecessary megasas_use_msix(), Cao jin, 2016/10/19
- [Qemu-devel] [PATCH v4 10/10] msi_init: convert assert to return -errno, Cao jin, 2016/10/19
- [Qemu-devel] [PATCH v4 09/10] vmxnet3: remove unnecessary internal msix flag, Cao jin, 2016/10/19
- Re: [Qemu-devel] [PATCH v4 00/10] Convert msix_init() to error, Michael S. Tsirkin, 2016/10/30