qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2 08/11] tests: Clean up IO handling in ide-test


From: Laurent Vivier
Subject: Re: [Qemu-devel] [PATCHv2 08/11] tests: Clean up IO handling in ide-test
Date: Wed, 19 Oct 2016 16:43:48 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0


On 19/10/2016 14:25, David Gibson wrote:
> ide-test uses many explicit inb() / outb() operations for its IO, which
> means it's not portable to non-x86 platforms.  This cleans it up to use
> the libqos PCI accessors instead.
> 
> Signed-off-by: David Gibson <address@hidden>
> ---
>  tests/ide-test.c | 179 
> ++++++++++++++++++++++++++++++++++++-------------------
>  1 file changed, 118 insertions(+), 61 deletions(-)

Could explain why you have swapped the le16_to_cpu() and cpu_to_le16()?

For me, they were correct.

Thanks,
Laurent



reply via email to

[Prev in Thread] Current Thread [Next in Thread]