Re: [Qemu-devel] [ndctl PATCH 0/8] dimm label space initialization support

[Dan Williams]

On Thu, Oct 20, 2016 at 12:32 PM, Vishal Verma <address@hidden> wrote:
> On 10/19, Dan Williams wrote:
>> The 4.9 kernel added support for sub-dividing PMEM.  With this kernel
>> patch [1] on top of that baseline, the PMEM-sub-division support can be
>> enabled for QEMU-KVM and any other platforms that advertise both un-aliased
>> PMEM regions and support for the label DSM commands [2].
>>
>> Given this increasing need to perform a label management operation
>> across a set of DIMMs this update also adds glob(3) support.  For
>> example you can now write commands like:
>>
>>     ndctl zero-labels nmem[2-4]
>>
>> ...as a shorthand for:
>>
>>     ndctl zero-labels nmem2 nmem3 nmem4
>>
>> This support extends to all the commands that take an undecorated dimm /
>> nmem device as a parameter:
>>
>>     disable-dimm
>>     enable-dimm
>>     read-labels
>>     zero-labels
>>     init-labels
>>     check-labels
>>
>> The patch "libndctl: fix error returns for unsigned apis" was something
>> noticed while developing "init-labels", but is otherwise unrelated to
>> the rest of the set.
>>
>> [1]: https://patchwork.kernel.org/patch/9384741/
>> [2]: http://pmem.io/documents/NVDIMM_DSM_Interface_Example-V1.2.pdf
>>
>> ---
>>
>> Dan Williams (8):
>>       libndctl: fix error returns for unsigned apis
>>       ndctl: consolidate label commands into a single file
>>       ndctl: glob support for label commands
>>       ndctl: merge {enable,disable}-dimm with label commands
>>       libndctl: add ndctl_cmd_cfg_read_get_size()
>>       ndctl: provide a read_labels() helper
>>       ndctl: init-labels command
>>       ndctl: check-labels command
>>
>
> Hi Dan,
>
> Here is the bash completion patch for the new commands:
>
> 8<-----
>
>
> From 53e3090ecd124562540bb25948783c33d9390112 Mon Sep 17 00:00:00 2001
> From: Vishal Verma <address@hidden>
> Date: Thu, 20 Oct 2016 13:29:03 -0600
> Subject: [PATCH] ndctl: bash completion for {init, check}-labels
>
> Add bash completion for the new init-labels and check-labels commands.
>
> Signed-off-by: Vishal Verma <address@hidden>
> ---
>  contrib/ndctl | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/contrib/ndctl b/contrib/ndctl
> index 2c04504..ea7303c 100755
> --- a/contrib/ndctl
> +++ b/contrib/ndctl
> @@ -206,6 +206,10 @@ __ndctl_comp_non_option_args()
>         disable-dimm)
>                 opts="$(__ndctl_get_dimms) all"
>                 ;;
> +       init-labels)
> +               ;&
> +       check-labels)
> +               ;&
>         read-labels)
>                 ;&
>         zero-labels)

Thanks, applied.