[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] chardev's and fd's in monitors
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] chardev's and fd's in monitors |
Date: |
Fri, 21 Oct 2016 12:56:03 +0100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
* Daniel P. Berrange (address@hidden) wrote:
> On Fri, Oct 21, 2016 at 11:06:21AM +0200, Markus Armbruster wrote:
> > "Dr. David Alan Gilbert" <address@hidden> writes:
> >
> > > * Markus Armbruster (address@hidden) wrote:
> > >> "Daniel P. Berrange" <address@hidden> writes:
> > [...]
> > >> > Realistically all the major backend subsystems (chardev, network,
> > >> > block,
> > >> > ui and migration) need to be converted to Error ** propagation, since
> > >> > they all ultimately call into some common code that reports Error **.
> > >>
> > >> Infrastucture generally doesn't know how it's used, which means
> > >> error_report() is generally wrong there. Sufficiently simple functions
> > >> can keep returning -errno, null, whatever, but the interesting stuff
> > >> needs to use Error.
> > >> > Very few places will end up being able to stick with -errno, or plain
> > >> > error_report in the long term.
> > >>
> > >> Not sure about "very few". Less than now. We'll see.
> > >
> > > I'd also prefer we got the very-few level; Migration used to be
> > > characterised by getting a 'load of migration failed -22' and having
> > > no clue in the logs to why; I've slowly fought back to be able
> > > to get an error from the lowest level that caused the failure.
> > > I want more of that, so that when someone gets a rare failure in the field
> > > I can see why.
> >
> > When it's about details that are only useful for debugging, logging
> > might be a practical alternative. No excuse for shoddy error reporting,
> > of course.
>
> FWIW, I would very much like it if incoming migration were able to report
> the error failing to load migration stream back via the monitor, instead
> of spitting them to stderr - the latter makes it hard for libvirt to
> provide good error report to the users.
As long as we also get them in the stderr log then that's fine.
Dave
> On the outgoing side we've now fed the errors back via the query-migrate
> command - the same approach could be used on the incoming side.
>
>
> Regards,
> Daniel
> --
> |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org -o- http://virt-manager.org :|
> |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] chardev's and fd's in monitors, (continued)
- Re: [Qemu-devel] chardev's and fd's in monitors, Dr. David Alan Gilbert, 2016/10/20
- Re: [Qemu-devel] chardev's and fd's in monitors, Markus Armbruster, 2016/10/20
- Re: [Qemu-devel] chardev's and fd's in monitors, Dr. David Alan Gilbert, 2016/10/20
- Re: [Qemu-devel] chardev's and fd's in monitors, Daniel P. Berrange, 2016/10/20
- Re: [Qemu-devel] chardev's and fd's in monitors, Markus Armbruster, 2016/10/20
- Re: [Qemu-devel] chardev's and fd's in monitors, Daniel P. Berrange, 2016/10/20
- Re: [Qemu-devel] chardev's and fd's in monitors, Markus Armbruster, 2016/10/20
- Re: [Qemu-devel] chardev's and fd's in monitors, Dr. David Alan Gilbert, 2016/10/20
- Re: [Qemu-devel] chardev's and fd's in monitors, Markus Armbruster, 2016/10/21
- Re: [Qemu-devel] chardev's and fd's in monitors, Daniel P. Berrange, 2016/10/21
- Re: [Qemu-devel] chardev's and fd's in monitors,
Dr. David Alan Gilbert <=
- Re: [Qemu-devel] chardev's and fd's in monitors, Dr. David Alan Gilbert, 2016/10/21
- Re: [Qemu-devel] chardev's and fd's in monitors, Paolo Bonzini, 2016/10/19
- Re: [Qemu-devel] chardev's and fd's in monitors, Dr. David Alan Gilbert, 2016/10/19
- Re: [Qemu-devel] chardev's and fd's in monitors, Paolo Bonzini, 2016/10/19
- Re: [Qemu-devel] chardev's and fd's in monitors, Daniel P. Berrange, 2016/10/20
Re: [Qemu-devel] chardev's and fd's in monitors, Markus Armbruster, 2016/10/18
Re: [Qemu-devel] chardev's and fd's in monitors, Daniel P. Berrange, 2016/10/18