[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] exec.c: ensure all AddressSpaceDispatch updates und
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PATCH] exec.c: ensure all AddressSpaceDispatch updates under RCU |
Date: |
Fri, 21 Oct 2016 16:34:18 +0100 |
The memory_dispatch field is meant to be protected by RCU so we should
use the correct primitives when accessing it. This race was flagged up
by the ThreadSanitizer.
Signed-off-by: Alex Bennée <address@hidden>
---
exec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/exec.c b/exec.c
index 738e8ba..c5e4073 100644
--- a/exec.c
+++ b/exec.c
@@ -459,7 +459,7 @@ address_space_translate_for_iotlb(CPUState *cpu, int asidx,
hwaddr addr,
hwaddr *xlat, hwaddr *plen)
{
MemoryRegionSection *section;
- AddressSpaceDispatch *d = cpu->cpu_ases[asidx].memory_dispatch;
+ AddressSpaceDispatch *d =
atomic_rcu_read(&cpu->cpu_ases[asidx].memory_dispatch);
section = address_space_translate_internal(d, addr, xlat, plen, false);
@@ -2342,7 +2342,7 @@ static void tcg_commit(MemoryListener *listener)
* may have split the RCU critical section.
*/
d = atomic_rcu_read(&cpuas->as->dispatch);
- cpuas->memory_dispatch = d;
+ atomic_rcu_set(&cpuas->memory_dispatch, d);
tlb_flush(cpuas->cpu, 1);
}
--
2.9.3
- [Qemu-devel] [PATCH] exec.c: ensure all AddressSpaceDispatch updates under RCU,
Alex Bennée <=