|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH v3 2/3] utils: Add helper to read arm MIDR_EL1 register |
Date: | Mon, 24 Oct 2016 08:47:00 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 10/23/2016 10:55 PM, address@hidden wrote: > +static uint64_t aarch64_midr_val; > +uint64_t get_aarch64_cpu_id(void) > +{ > +#ifdef CONFIG_LINUX > + aarch64_midr_val = qemu_read_aarch64_midr_el1(); > + aarch64_midr_val &= CPU_MODEL_MASK; > + > + return aarch64_midr_val; > +#else > + return 0; > +#endif > +} > + > +bool is_thunderx_pass2_cpu(void) > +{ > + return aarch64_midr_val == MIDR_THUNDERX_PASS2; > +} Any particular reason why you want to keep midr_val and MIDR_THUNDERX private to this file? Seems like it would be cheaper to export those in the header. r~
[Prev in Thread] | Current Thread | [Next in Thread] |