[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/35] cmpxchg atomic operations
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PULL 00/35] cmpxchg atomic operations |
Date: |
Mon, 24 Oct 2016 10:27:10 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 10/24/2016 03:51 AM, Peter Maydell wrote:
> /Users/pm215/src/qemu-for-merges/target-arm/translate.c:1019:1: error:
> unused function 'gen_aa32_ld16ua
> ' [-Werror,-Wunused-function]
> DO_GEN_LD(16ua, MO_UW | MO_ALIGN)
> ^
> /Users/pm215/src/qemu-for-merges/target-arm/translate.c:954:20: note:
> expanded from macro 'DO_GEN_LD'
> static inline void gen_aa32_ld##SUFF(DisasContext *s, TCGv_i32 val, \
> ^
> <scratch space>:130:1: note: expanded from here
> gen_aa32_ld16ua
> ^
> /Users/pm215/src/qemu-for-merges/target-arm/translate.c:1020:1: error:
> unused function 'gen_aa32_ld32ua
> ' [-Werror,-Wunused-function]
> DO_GEN_LD(32ua, MO_UL | MO_ALIGN)
Bah. Annoyingly, even though I didn't configure with --disable-werror, I only
got the warning from clang, which of course flashed by unseen.
Folded the removal of these into the "target-arm: emulate LL/SC using cmpxchg
helpers" patch which removed their use.
r~
- [Qemu-devel] [PULL 32/35] linux-user: remove handling of aarch64's EXCP_STREX, (continued)
- [Qemu-devel] [PULL 32/35] linux-user: remove handling of aarch64's EXCP_STREX, Richard Henderson, 2016/10/22
- [Qemu-devel] [PULL 30/35] target-arm: emulate aarch64's LL/SC using cmpxchg helpers, Richard Henderson, 2016/10/22
- [Qemu-devel] [PULL 33/35] target-arm: remove EXCP_STREX + cpu_exclusive_{test, info}, Richard Henderson, 2016/10/22
- [Qemu-devel] [PULL 34/35] target-alpha: Introduce MMU_PHYS_IDX, Richard Henderson, 2016/10/22
- [Qemu-devel] [PULL 27/35] target-arm: Rearrange aa32 load and store functions, Richard Henderson, 2016/10/22
- [Qemu-devel] [PULL 31/35] linux-user: remove handling of ARM's EXCP_STREX, Richard Henderson, 2016/10/22
- [Qemu-devel] [PULL 35/35] target-alpha: Emulate LL/SC using cmpxchg helpers, Richard Henderson, 2016/10/22
- Re: [Qemu-devel] [PULL 00/35] cmpxchg atomic operations, Peter Maydell, 2016/10/24