[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature |
Date: |
Wed, 26 Oct 2016 08:42:27 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 10/26/2016 01:07 AM, Amit Shah wrote:
> On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote:
>> configure --enable-colo/--disable-colo to switch COLO
>> support on/off.
>> COLO feature is enabled by default.
>>
>> Signed-off-by: zhanghailiang <address@hidden>
>> Signed-off-by: Li Zhijian <address@hidden>
>> Signed-off-by: Gonglei <address@hidden>
>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>
> Reviewed-by: Amit Shah <address@hidden>
>
>> v19:
>> - fix colo_supported() to return true
>> v11:
>> - Turn COLO on in default (Eric's suggestion)
>
> Can you recap why the suggestion was made to switch it on by default?
If the feature doesn't depend on external libraries, then enabling
compilation by default will avoid bitrot.
But mentioning this rationale in the commit message never hurts :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH COLO-Frame (Base) v21 12/17] COLO: Add 'x-colo-lost-heartbeat' command to trigger failover, zhanghailiang, 2016/10/18
[Qemu-devel] [PATCH COLO-Frame (Base) v21 06/17] COLO: Introduce checkpointing protocol, zhanghailiang, 2016/10/18