[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_prope
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_property_add() in new code |
Date: |
Wed, 26 Oct 2016 14:30:26 -0200 |
The only remaining user of object_class_property_add() is
arm_cpu_post_init(), but removing it may take some work. While we
don't change it, warn people to not use the function in new code.
Cc: Peter Maydell <address@hidden>
Cc: address@hidden
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/core/qdev.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index a88753c..53cbaad 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -813,6 +813,10 @@ static void qdev_property_set_to_default(DeviceState *dev,
Property *prop,
* Add a static QOM property to @dev for qdev property @prop.
* On error, store error in @errp. Static properties access data in a struct.
* The type of the QOM property is derived from prop->info.
+ *
+ * Do not use this in new code. Either use qdev_class_set_props(),
+ * or register regular QOM properties using object_property_add() or
+ * object_class_property_add().
*/
void qdev_property_add_static(DeviceState *dev, Property *prop,
Error **errp)
--
2.7.4
- [Qemu-devel] [PATCH v3 4/8] qdev: Extract property-default code to qdev_property_set_to_default(), (continued)
[Qemu-devel] [PATCH v3 7/8] qmp: Support abstract classes on device-list-properties, Eduardo Habkost, 2016/10/26
[Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_property_add() in new code,
Eduardo Habkost <=
[Qemu-devel] [PATCH v3 3/8] qdev: device_class_set_props() function, Eduardo Habkost, 2016/10/26
Re: [Qemu-devel] [PATCH v3 0/8] qdev class properties + abstract class support on device-list-properties, Eduardo Habkost, 2016/10/27