[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] 9pfs: drop abusive error message from virtfs_re
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] 9pfs: drop abusive error message from virtfs_reset() |
Date: |
Mon, 31 Oct 2016 13:59:06 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 10/28/2016 05:26 PM, Greg Kurz wrote:
> The virtfs_reset() function is called either when the virtio-9p device
> gets reset, or when the client starts a new 9P session. In both cases,
> if it finds fids from a previous session, the following is printed in
> the monitor:
>
> 9pfs:virtfs_reset: One or more uncluncked fids found during reset
What's more, the error message had a typo. Good riddance.
>
> For example, if a linux guest with a mounted 9P share is reset from the
> monitor with system_reset, the message will be printed. This is abusive
> since these fids are now clunked and the state is clean.
>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> hw/9pfs/9p.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Improvement by deletion is always fun.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature