[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/29] target-sparc: hypervisor mode takes over
Re: [Qemu-devel] [PATCH 09/29] target-sparc: hypervisor mode takes over nucleus mode
Tue, 1 Nov 2016 13:29:15 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
On 11/01/2016 12:12 PM, Artyom Tarasenko wrote:
While playing with your patch set, I discovered that we also need a
patch to get_asi for ASI_N et al to retain MMU_HYPV_IDX, and not
decrease privilege. This happens *very* early in the prom boot, with
the first casx (when casx is implemented inline).
Why is the bug not visible with the current master? I wonder if we
have a symmetrical bug somewhere.
Hmm, I dunno. I assume it has something to do with casx being implemented
out of line, and using helper_ld_asi instead of tcg_gen_qemu_ld_tl directly.
Actually I don't see where the privilege is decreased: get_asi uses a
local mem_idx variable, the dc->mem_idx is retained.
What patch do you have in mind?
Like this. Anyway, now that PMM has my atomic and sparc patch sets, you should
be able to see the problem yourself with your patch set and your rom.
Description: Text document