|
From: | Jason Wang |
Subject: | Re: [Qemu-devel] [PATCH 1/1] net: skip virtio-net config of deleted nic's peers |
Date: | Wed, 2 Nov 2016 10:58:10 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 2016年11月01日 06:42, Michael S. Tsirkin wrote:
On Tue, Nov 01, 2016 at 12:01:17AM +0200, address@hidden wrote:From: Yuri Benditovich <address@hidden> https://bugzilla.redhat.com/show_bug.cgi?id=1373816 qemu core dump happens during repetitive unpug-plug with multiple queues and Windows RSS-capable guest. If back-end delete requested during virtio-net device initialization, driver still can try configure the device for multiple queues. The virtio-net device is expected to be removed as soon as the initialization is done. Signed-off-by: Yuri Benditovich <address@hidden>Reviewed-by: Michael S. Tsirkin <address@hidden>
Applied to -net, thanks.
--- hw/net/virtio-net.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 06bfe4b..77a4fae 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -508,6 +508,10 @@ static void virtio_net_set_queues(VirtIONet *n) int i; int r;+ if (n->nic->peer_deleted) {+ return; + } + for (i = 0; i < n->max_queues; i++) { if (i < n->curr_queues) { r = peer_attach(n, i); -- 1.9.1
[Prev in Thread] | Current Thread | [Next in Thread] |