[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v3] block/nbd: Fix the leaked visitor

From: Ashijeet Acharya
Subject: [Qemu-devel] [PATCH v3] block/nbd: Fix the leaked visitor
Date: Wed, 2 Nov 2016 16:10:03 +0530

This patch frees the leaked visitor in nbd_refresh_filename() and uses
visit_free() to fix it. The leak was introduced by the commit 491d6c7.

Signed-off-by: Ashijeet Acharya <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Changes in v3:
- Modify the Subject line
- Free the visitor immediately after visit_complete()
 block/nbd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/nbd.c b/block/nbd.c
index 8ef1438..d656eb1 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -534,6 +534,7 @@ static void nbd_refresh_filename(BlockDriverState *bs, 
QDict *options)
     ov = qobject_output_visitor_new(&saddr_qdict);
     visit_type_SocketAddress(ov, NULL, &s->saddr, &error_abort);
     visit_complete(ov, &saddr_qdict);
+    visit_free(ov);
     assert(qobject_type(saddr_qdict) == QTYPE_QDICT);
     qdict_put_obj(opts, "server", saddr_qdict);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]