[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/19] block: Fix some filename generation issue
Re: [Qemu-devel] [PATCH 00/19] block: Fix some filename generation issues
Wed, 02 Nov 2016 16:00:49 +0100
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)
On Tue 26 Apr 2016 11:31:59 PM CEST, Max Reitz wrote:
> There are some issues regarding filename generation right now:
> - You always get a JSON filename if you set even a single qcow2-specific
> runtime options (as long as it does not have a dot in it, which is a
> bug, too, but here it is working in our favor...). That is not nice
> and actually breaks the usage of backing files with relative
> filenames with such qcow2 BDS.
> - As hinted above, you cannot use relative backing filenames with BDS
> that have a JSON filename only, even though qemu might be able to
> obtain the directory name by walking through the BDS graph to the
> protocol level.
> - Overriding the backing file at runtime should invalidate the filename
> because it actually changes the BDS's data. Therefore, we need to
> force a JSON filename in that case, containing the backing file
> - Much of our code assumes paths never to exceed PATH_MAX in length.
> This is wrong, at least because of JSON filenames. This should be
> fixed wherever the opportunity arises.
I'd like to retake the review of this series. It can be rebased easily
and it still seems to work fine. Shall I take a look at the patches as
they are now or shall I better wait for a new version?
- Re: [Qemu-devel] [PATCH 00/19] block: Fix some filename generation issues,
Alberto Garcia <=