Re: [Qemu-devel] [PATCH 0/5] ARM BE8/BE32 big-endian system-mode fixes (semihosting, gdbstub)

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH 0/5] ARM BE8/BE32 big-endian system-mode fixes 
(semihosting, gdbstub)
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
fed6fdc Fix typo in arm_cpu_do_interrupt_aarch32.
8e8228b ARM BE32 watchpoint fix.
c35a16c Fix arm_semi_flen_cb for BE32 system mode.
34c88b7 Fix Thumb-1 BE32 execution and disassembly.
23bc6c4 ARM BE8/BE32 semihosting and gdbstub support.

=== OUTPUT BEGIN ===
fatal: unrecognized argument: --no-patch
Checking PATCH 1/5: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 2/5: ...
ERROR: suspect code indent for conditional statements (6, 10)
#42: FILE: disas/arm.c:3919:
+      if (is_thumb1_be32) {
+          status = info->read_memory_func(pc & ~3, (bfd_byte *)b, 4, info);

ERROR: suspect code indent for conditional statements (10, 14)
#45: FILE: disas/arm.c:3922:
+          if ((pc & 2) == 0) {
+              given = b[2] | (b[3] << 8);

ERROR: suspect code indent for conditional statements (10, 14)
#52: FILE: disas/arm.c:3929:
+          if (little) {
+              given = (b[0]) | (b[1] << 8);

ERROR: suspect code indent for conditional statements (14, 18)
#70: FILE: disas/arm.c:3944:
+              if (is_thumb1_be32) {
+                  status = info->read_memory_func((pc + 2) & ~3,

ERROR: suspect code indent for conditional statements (18, 22)
#73: FILE: disas/arm.c:3947:
+                  if (((pc + 2) & 2) == 0) {
+                      given = b[2] | (b[3] << 8) | (given << 16);

ERROR: suspect code indent for conditional statements (18, 22)
#81: FILE: disas/arm.c:3955:
+                  if (little) {
+                      given = (b[0]) | (b[1] << 8) | (given << 16);

total: 6 errors, 0 warnings, 100 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

fatal: unrecognized argument: --no-patch
Checking PATCH 3/5: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 4/5: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 5/5: ...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden