[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [V3,1/7] nios2: Add disas entries

From: Guenter Roeck
Subject: Re: [Qemu-devel] [V3,1/7] nios2: Add disas entries
Date: Sun, 6 Nov 2016 22:33:41 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 11/06/2016 08:17 PM, Sandra Loosemore wrote:
On 11/06/2016 08:55 PM, Guenter Roeck wrote:
On Tue, Oct 18, 2016 at 11:50:25PM +0200, Marek Vasut wrote:
Add nios2 disassembler support. This patch is composed from binutils files
from commit "Opcodes and assembler support for Nios II R2". The files from
binutils used in this patch are:


Signed-off-by: Marek Vasut <address@hidden>
Cc: Chris Wulff <address@hidden>
Cc: Jeff Da Silva <address@hidden>
Cc: Ley Foon Tan <address@hidden>
Cc: Sandra Loosemore <address@hidden>
Cc: Yves Vandervennet <address@hidden>
V3: No change
V2: Replace the nios2.c with GPL2 licensed version

checkpatch.pl reports:

total: 1967 errors, 150 warnings, 3559 lines checked

on this file. When applying it, git reports a number of whitespace problems.

Is that expected ?


I don't know what checkpatch.pl is, or what "errors" it might be complaining 
about, but I'd strongly discourage doing anything to this code that would cause it to 
diverge from the binutils code it was derived from, even trivial whitespace changes.  
That would only complicate propagating updates to the code to both components.  (I can't 
say I have any such patches in my queue right now, but I also can't rule out such changes 
in the future....)

-Sandra the nios2 binutils maintainer

May I suggest adding a comment along that line to the commit log ?

FWIW, "git am" says:

$ git am -s index.html
Applying: nios2: Add disas entries
/opt/buildbot/qemu/qemu/.git/rebase-apply/patch:124: trailing whitespace.
/* This structure holds information for a particular instruction.
/opt/buildbot/qemu/qemu/.git/rebase-apply/patch:180: trailing whitespace.
  const char *args;             /* A string describing the arguments for this
/opt/buildbot/qemu/qemu/.git/rebase-apply/patch:182: trailing whitespace.
  const char *args_test;        /* Like args, but with an extra argument for
/opt/buildbot/qemu/qemu/.git/rebase-apply/patch:184: trailing whitespace.
  unsigned long num_args;       /* The number of arguments the instruction
/opt/buildbot/qemu/qemu/.git/rebase-apply/patch:189: trailing whitespace.
  unsigned long mask;           /* Mask for the opcode field of the
warning: squelched 107 whitespace errors
warning: 112 lines add whitespace errors.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]