[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 01/14] qapi: add missing 'bus' argument in de
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 01/14] qapi: add missing 'bus' argument in device_add |
Date: |
Mon, 07 Nov 2016 16:10:34 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> 'device_add' is incomplete for now, but 'bus' is a common argument for
> regarless of the device, and is present in documentation. Add it to the
> device_add schema definition.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> qapi-schema.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index b0b4bf6..4ba5772 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -2317,7 +2317,7 @@
> # Since: 0.13
> ##
> { 'command': 'device_add',
> - 'data': {'driver': 'str', 'id': 'str'},
> + 'data': {'driver': 'str', '*bus': 'str', 'id': 'str'},
> 'gen': false } # so we can get the additional arguments
>
> ##
Makes sense.
@id is actually optional, care to fix that, too?
- [Qemu-devel] [PATCH v3 00/14] qapi doc generation (whole version, squashed), Marc-André Lureau, 2016/11/07
- [Qemu-devel] [PATCH v3 01/14] qapi: add missing 'bus' argument in device_add, Marc-André Lureau, 2016/11/07
- [Qemu-devel] [PATCH v3 02/14] qga/schema: fix double-return in doc, Marc-André Lureau, 2016/11/07
- [Qemu-devel] [PATCH v3 03/14] qga/schema: improve guest-set-vcpus Returns: section, Marc-André Lureau, 2016/11/07
- [Qemu-devel] [PATCH v3 05/14] qapi: fix missing symbol @prefix, Marc-André Lureau, 2016/11/07
- [Qemu-devel] [PATCH v3 04/14] qapi: fix schema symbol sections, Marc-André Lureau, 2016/11/07
- [Qemu-devel] [PATCH v3 06/14] qapi: fix various symbols mismatch in documentation, Marc-André Lureau, 2016/11/07