[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH Risu v2 0/9] Risu support for PPC64LE

From: joserz
Subject: Re: [Qemu-devel] [PATCH Risu v2 0/9] Risu support for PPC64LE
Date: Mon, 7 Nov 2016 18:18:25 -0200
User-agent: Mutt/1.5.24 (2015-08-30)

On Mon, Nov 07, 2016 at 04:43:38PM +0000, Peter Maydell wrote:
> On 6 November 2016 at 17:15, Jose Ricardo Ziviani
> <address@hidden> wrote:
> > v2:
> >  - smaller commits
> >  - improved registers comparison
> >  - improved code style
> >  - fixed copyright lines
> >
> > TODOs:
> >  - improve load/store instruction generation (risugen)
> >  - improve initial random values for FP and Vector regs (risugen)
> >  - make write_test_code() generic (risugen)
> The files risu_reginfo_ppc64le.h and ppc64.risu both still
> claim to be copyright Linaro Limited. Please can you confirm that
> I should change those to read 'Copyright (c) IBM Corp, 2016'
> like the other new files you have written?
> I've also written a trivial fix which uses 'sort keys %insn_details'
> rather than just 'keys %insn_details' so that the output binary
> remains the same if you run risugen twice with the same arguments;
> I then had to propagate that fix to the new places where that
> code got copied.
> It would be good to have a 'utils' module which gets used
> by the arch specific modules so we can avoid having duplicate
> functions between all the arch specific modules, but we can
> do that as a separate cleanup after this lot.
> If you give me the OK to fix up the copyright lines I can push
> this patchset to risu master.
> thanks
> -- PMM

Hello Peter,

Yes, my bad again. You can fix these copyright lines.
I intend to continue working on it, so I'll create a todo list with some
suggestions I have and share that with you so you can modify/add as

Thank you very much for your review!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]