[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] BdrvDirtyBitmap and bdrv_snapshot_goto

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-devel] BdrvDirtyBitmap and bdrv_snapshot_goto
Date: Tue, 8 Nov 2016 14:08:17 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

08.11.2016 14:05, Kevin Wolf wrote:
Am 07.11.2016 um 17:10 hat Max Reitz geschrieben:
On 07.11.2016 16:24, Vladimir Sementsov-Ogievskiy wrote:
Hi all!

As I can see, in bdrv_snapshot_goto, existing dirty bitmaps are not
handled.. Is it ok? Should not they be filled with ones or something
like this?
Filling them with ones makes sense to me. I guess nobody noticed because
nobody was crazy enough to use block jobs alongside loadvm...
What's the use case in which ones make sense?

It rather seems to me that an active dirty bitmap and snapshot switching
should exclude each other because the bitmap becomes meaningless by the
switch. And chances are that after switching a snapshot you don't want
to "incrementally" backup everything, but that you should access a
different backup.


In other words, dirty bitmaps should be deleted on snapshot switch? All? Or only named?

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]