[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V10] fsdev: add IO throttle support to fsdev dev
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-devel] [PATCH V10] fsdev: add IO throttle support to fsdev devices |
|
Date: |
Wed, 09 Nov 2016 11:23:46 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 09 Nov 2016 10:50:40 AM CET, Pradeep Jagadeesh wrote:
> Uses throttling APIs to limit I/O bandwidth and number of operations
> on the devices which use 9p-local driver.
>
> Signed-off-by: Pradeep Jagadeesh <address@hidden>
It looks good now, thanks!
> +void fsdev_throttle_parse_opts(QemuOpts *opts, FsThrottle *fst, Error **err)
> +{
[...]
> + throttle_is_valid(&fst->cfg, err);
> +}
Following the QEMU conventions, I would still rename 'err' to 'errp' in
this function (since it's an Error **).
Otherwise,
Reviewed-by: Alberto Garcia <address@hidden>
Berto