[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/3] Introduce vhost-user-scsi and sample app
Michael S. Tsirkin
Re: [Qemu-devel] [PATCH v2 0/3] Introduce vhost-user-scsi and sample application
Thu, 10 Nov 2016 15:56:50 +0200
On Thu, Nov 10, 2016 at 05:49:16AM -0800, Felipe Franciosi wrote:
> Based on various discussions on the 2016 KVM Forum, I'm sending over a
> vhost-user-scsi implementation for your consideration.
> This patch set introduces a new vhost-user SCSI device. While heavily
> based on vhost-scsi, it is implemented using vhost's userspace
> counterpart. The device has been coded and tested to work with live
> As part of this work, a new vhost-scsi-common device was created and
> the existing vhost-scsi device moved underneath it. The new
> vhost-user-scsi device is also placed underneath it.
> A sample application based on the newly introduced libvhost-user is
> also included. It makes use of libiscsi for simplicity.
> For convenience, I'm maintaining an up-to-date version of these
> patches (including some necessary fixes for libvhost-user and vhost
> core code still under discussion) on:
> See the individual patches for build and use instructions.
> Signed-off-by: Felipe Franciosi <address@hidden>
I'll review after we put out the release, pls remember
to ping then.
I would like to get some feedback from storage maintainers
on whether they see issues with supporting this.
> v1 -> v2:
> - Introduce new vhost-scsi-common device type.
> - Move vhost-scsi device underneath vhost-scsi-common.
> - Move sample application from tests/ to contrib/.
> - Make sample application use the glib event loop.
> - Minor fixes.
> Felipe Franciosi (3):
> vhost-scsi: create a vhost-scsi-common abstraction
> vus: Introduce vhost-user-scsi host device
> vus: Introduce a vhost-user-scsi sample application
> Makefile | 4 +
> Makefile.objs | 4 +
> configure | 11 +
> contrib/vhost-user-scsi/Makefile.objs | 1 +
> contrib/vhost-user-scsi/vhost-user-scsi.c | 886
> hw/scsi/Makefile.objs | 3 +-
> hw/scsi/vhost-scsi-common.c | 143 +++++
> hw/scsi/vhost-scsi.c | 188 ++-----
> hw/scsi/vhost-user-scsi.c | 198 +++++++
> hw/virtio/virtio-pci.c | 58 ++
> hw/virtio/virtio-pci.h | 15 +
> include/hw/virtio/vhost-scsi-common.h | 48 ++
> include/hw/virtio/vhost-scsi.h | 11 +-
> include/hw/virtio/vhost-user-scsi.h | 34 ++
> include/hw/virtio/virtio-scsi.h | 7 +
> 15 files changed, 1466 insertions(+), 145 deletions(-)
> create mode 100644 contrib/vhost-user-scsi/Makefile.objs
> create mode 100644 contrib/vhost-user-scsi/vhost-user-scsi.c
> create mode 100644 hw/scsi/vhost-scsi-common.c
> create mode 100644 hw/scsi/vhost-user-scsi.c
> create mode 100644 include/hw/virtio/vhost-scsi-common.h
> create mode 100644 include/hw/virtio/vhost-user-scsi.h