Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

[Christian Borntraeger]

On 11/10/2016 03:38 PM, Paolo Bonzini wrote:
> 
> 
> On 10/11/2016 15:35, Christian Borntraeger wrote:
>> On 10/30/2016 10:23 PM, Michael S. Tsirkin wrote:
>>> From: Paolo Bonzini <address@hidden>
>>>
>>> Now that there is not anymore a switch from the generic ioeventfd handler
>>> to the dataplane handler, virtio_bus_set_host_notifier(assign=true) is
>>> always called with !bus->ioeventfd_started, hence virtio_bus_stop_ioeventfd
>>> does nothing in this case.  Move the invocation to vhost.c, which is the
>>> only place that needs it.
>>>
>>> Reviewed-by: Cornelia Huck <address@hidden>
>>> Signed-off-by: Paolo Bonzini <address@hidden>
>>> Reviewed-by: Michael S. Tsirkin <address@hidden>
>>> Signed-off-by: Michael S. Tsirkin <address@hidden>
>>> ---
>>>  include/hw/virtio/virtio-bus.h |  6 ------
>>>  hw/virtio/vhost.c              |  3 +++
>>>  hw/virtio/virtio-bus.c         | 23 ++++++++---------------
>>>  3 files changed, 11 insertions(+), 21 deletions(-)
>>
>> This breaks vhost-net for s390/kvm after rebooting the guest. (ping fails and
>> ifconfig shows no packets is TXed)
>>
>> Any idea?
> 
> Patch from Felipe:
> [PATCH v2] vhost: Update 'ioeventfd_started' with host notifiers
> 
> Paolo

Yes, that fixes the issue