[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 15/19] target-arm/cpu: don't reset TLB struct

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v6 15/19] target-arm/cpu: don't reset TLB structures, use cputlb to do it
Date: Thu, 10 Nov 2016 18:48:01 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 11/09/2016 03:57 PM, Alex Bennée wrote:
+    memset(env, 0, offsetof(CPUARMState, tlb_table));
+    tlb_flush(s, 0);
     memset(env, 0, offsetof(CPUARMState, features));

I'd really prefer to see the tlb_flush be moved into parent_reset, so that we handle it identically for all targets.

As for the memset, do we really need to distinguish softmmu? I don't like you picking out a variable name within CPU_COMMON. Better to use empty struct markers, like the

      struct {} start_init_save;

that x86 uses.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]