Re: [Qemu-devel] [PATCH v4] target-m68k: add rol/ror/roxl/roxr instructions

[Richard Henderson]

On 11/11/2016 10:25 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> v4:
>  - don't overwrite TCGv descriptor in rotate16_reg()
> v3:
>  - fix rotate memory decoding
>  - use "shx = shx < 0 ? size : shx;"
>  - some cleanup
> v2:
>  - use shift to do rotate_x() for 8 and 16bit value
>  - rotate_x()/rotate32_x() are  a no-op when shift % (size + 1) == 0
>  - add some missing tcg_temp_free()
>
>  target-m68k/translate.c | 391 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 391 insertions(+)

Reviewed-by: Richard Henderson <address@hidden>

> +/* Result of rotate_x() is valid if 0 <= shift < 32 */

Comment is wrong now -- 0 <= shift <= size.


r~