[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] target-m68k: add rol/ror/roxl/roxr instructi
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v4] target-m68k: add rol/ror/roxl/roxr instructions |
Date: |
Sat, 12 Nov 2016 09:27:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
Le 12/11/2016 à 09:26, Richard Henderson a écrit :
> On 11/11/2016 10:25 PM, Laurent Vivier wrote:
>> Signed-off-by: Laurent Vivier <address@hidden>
>> ---
>> v4:
>> - don't overwrite TCGv descriptor in rotate16_reg()
>> v3:
>> - fix rotate memory decoding
>> - use "shx = shx < 0 ? size : shx;"
>> - some cleanup
>> v2:
>> - use shift to do rotate_x() for 8 and 16bit value
>> - rotate_x()/rotate32_x() are a no-op when shift % (size + 1) == 0
>> - add some missing tcg_temp_free()
>>
>> target-m68k/translate.c | 391
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 391 insertions(+)
>
> Reviewed-by: Richard Henderson <address@hidden>
>
>> +/* Result of rotate_x() is valid if 0 <= shift < 32 */
>
> Comment is wrong now -- 0 <= shift <= size.
OK, I update the comment and put it in m68k-for-2.9
Thanks,
Laurent