[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] slirp: Fix access to freed memory
|
From: |
Samuel Thibault |
|
Subject: |
Re: [Qemu-devel] [PATCH] slirp: Fix access to freed memory |
|
Date: |
Mon, 14 Nov 2016 00:17:20 +0100 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Hello,
Note:
address@hidden, on Sun 13 Nov 2016 15:13:47 -0800, wrote:
> Your series seems to have some coding style problems. See output below for
> more information:
>
> === OUTPUT BEGIN ===
> fatal: unrecognized argument: --no-patch
> Checking PATCH 1/1: ...
> ERROR: suspect code indent for conditional statements (4, 6)
> #29: FILE: slirp/socket.c:74:
> + if (ifm->ifq_so == so) {
> + ifm->ifq_so = NULL;
>
> ERROR: suspect code indent for conditional statements (4, 6)
> #37: FILE: slirp/socket.c:82:
> + if (ifm->ifq_so == so) {
> + ifm->ifq_so = NULL;
This is due to that portion of the slirp code using 2-space indentation
instead of 4-space indentation.
Samuel