Re: [Qemu-devel] [PATCH v1 00/18] I/O prefetch cache

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v1 00/18] I/O prefetch cache
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
5b6050f block/pcache: debug build
e04563e block/pcache: add tracepoints
9cf4997 block/pcache: write through
84c80d3 block/pcache: drop used pcache nodes
a6bf468 backup/pcache: pick up parts of the cache
ad38071 block/pcache: inflight readahead request waiting for aio read
fb7ad9f block/pcache: add reading data from the cache
4850ad3 block/pcache: cache invalidation on AIO write requests
093b48c block/pcache: skip readahead for unallocated clusters
27fed87 block/pcache: add AIO readahead
8d1e3b6 block/pcache: updating statistics for overlapping requests
73db1d5 block/pcache: skip large aio read
5531940 block/pcache: statistics collection read requests
1f97985 tests/test-rbcache: add test cases
c523c4b util/rbcache: range-based cache core
ab4ef0c util/rbtree: add rbtree from linux kernel
929e891 block/pcache: empty pcache driver filter
99e7739 block/io: add bdrv_aio_{preadv, pwritev}

=== OUTPUT BEGIN ===
Checking PATCH 1/18: block/io: add bdrv_aio_{preadv, pwritev}...
Checking PATCH 2/18: block/pcache: empty pcache driver filter...
Checking PATCH 3/18: util/rbtree: add rbtree from linux kernel...
Checking PATCH 4/18: util/rbcache: range-based cache core...
Checking PATCH 5/18: tests/test-rbcache: add test cases...
Checking PATCH 6/18: block/pcache: statistics collection read requests...
Checking PATCH 7/18: block/pcache: skip large aio read...
Checking PATCH 8/18: block/pcache: updating statistics for overlapping 
requests...
Checking PATCH 9/18: block/pcache: add AIO readahead...
Checking PATCH 10/18: block/pcache: skip readahead for unallocated clusters...
Checking PATCH 11/18: block/pcache: cache invalidation on AIO write requests...
Checking PATCH 12/18: block/pcache: add reading data from the cache...
Checking PATCH 13/18: block/pcache: inflight readahead request waiting for aio 
read...
Checking PATCH 14/18: backup/pcache: pick up parts of the cache...
Checking PATCH 15/18: block/pcache: drop used pcache nodes...
Checking PATCH 16/18: block/pcache: write through...
Checking PATCH 17/18: block/pcache: add tracepoints...
Checking PATCH 18/18: block/pcache: debug build...
ERROR: do not use C99 // comments
#20: FILE: block/pcache.c:19:
+// #define PCACHE_DEBUG

total: 1 errors, 0 warnings, 84 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden