[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

From: Hervé Poussineau
Subject: Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value
Date: Wed, 16 Nov 2016 07:37:57 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0

Le 16/11/2016 à 07:29, P J P a écrit :
+-- On Wed, 16 Nov 2016, Hervé Poussineau wrote --+
| I don't have any datasheet for this device either, so I tested with real
| programs. Those initialize itr field to either 0 or to 9, so your mask
| doesn't change anything.
| Tested-by: Hervé Poussineau <address@hidden>

  Thank you so much. To confirm, do we need to update the mask to maybe

No, I think that 0x1ff is fine.
0xf mask means timers between 10ms to 1000ms
0x1ff mask means timers between 2ms to 1000ms, which seem also acceptable to me.


| > > >      case 0x0228:
| > > > -        s->itr = val;
| > > > +        s->itr = val & 0x01FF;
| > > >          qemu_irq_lower(s->timer_irq);

Thank you.
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

reply via email to

[Prev in Thread] Current Thread [Next in Thread]