[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwrit

From: Alberto Garcia
Subject: Re: [Qemu-devel] [RFC PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwritev()
Date: Fri, 18 Nov 2016 10:51:01 +0100
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Fri 11 Nov 2016 11:22:26 AM CET, Kevin Wolf wrote:

>> Honestly I don't see the point.  It seems easier, more practical and
>> more effective to convert bdrv_aio_* to byte ranges, especially since
>> QED would be basically a rewrite.
> Well, it's an RFC for a reason, I want people to give their opinions
> before consistently following through with this. But I do think that
> we pointlessly offer too many different interfaces to do the same
> thing in the block layer.

I cannot speak much about the AIO/coroutine interfaces (why do we have
both? is the latter supposed to supersede the former? I'd appreciate
some background here) but I did find the code easier to follow after
these patches, so from that point of view the series looks good to me.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]