[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol

From: Vincent Bernat
Subject: Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol
Date: Sun, 20 Nov 2016 09:42:46 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

 ❦ 19 novembre 2016 23:30 +0100, Samuel Thibault <address@hidden> :

>> > I think you should at least issue a qemu_log_mask(LOG_UNIMP, "...")
>> > call in that case.
>> I can do that if needed.
> That'd be better indeed. Otherwise people might wonder why things are
> not working. Warning that they have to do the LF -> CR,LF conversion by
> hand is important here.

I have sent an updated patch for that.

Totally unrelated, but on Debian, I have to use -r instead of -Wl,r for
LD_REL. This is explained here:

I don't think the patch has been forwarded to you yet.
Don't patch bad code - rewrite it.
            - The Elements of Programming Style (Kernighan & Plauger)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]