[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v3 00/10] aio: experimental virtio-blk polling mode

From: Stefan Hajnoczi
Subject: [Qemu-devel] [PATCH v3 00/10] aio: experimental virtio-blk polling mode
Date: Tue, 22 Nov 2016 16:31:36 +0000

 * Avoid ppoll(2)/epoll_wait(2) if polling succeeded [Paolo]
 * Disable guest->host virtqueue notification during polling [Christian]
 * Rebased on top of my virtio-blk/scsi virtqueue notification disable patches

 * Uninitialized node->deleted gone [Fam]
 * Removed 1024 polling loop iteration qemu_clock_get_ns() optimization which
   created a weird step pattern [Fam]
 * Unified with AioHandler, dropped AioPollHandler struct [Paolo]
   (actually I think Paolo had more in mind but this is the first step)
 * Only poll when all event loop resources support it [Paolo]
 * Added run_poll_handlers_begin/end trace events for perf analysis
 * Sorry, Christian, no virtqueue kick suppression yet

Recent performance investigation work done by Karl Rister shows that the
guest->host notification takes around 20 us.  This is more than the "overhead"
of QEMU itself (e.g. block layer).

One way to avoid the costly exit is to use polling instead of notification.
The main drawback of polling is that it consumes CPU resources.  In order to
benefit performance the host must have extra CPU cycles available on physical
CPUs that aren't used by the guest.

This is an experimental AioContext polling implementation.  It adds a polling
callback into the event loop.  Polling functions are implemented for virtio-blk
virtqueue guest->host kick and Linux AIO completion.

The QEMU_AIO_POLL_MAX_NS environment variable sets the number of nanoseconds to
poll before entering the usual blocking poll(2) syscall.  Try setting this
variable to the time from old request completion to new virtqueue kick.

By default no polling is done.  The QEMU_AIO_POLL_MAX_NS must be set to get any

Stefan Hajnoczi (10):
  virtio: add missing vdev->broken check
  virtio-blk: suppress virtqueue kick during processing
  virtio-scsi: suppress virtqueue kick during processing
  aio: add AioPollFn and io_poll() interface
  aio: add polling mode to AioContext
  virtio: poll virtqueues for new buffers
  linux-aio: poll ring for completions
  virtio: turn vq->notification into a nested counter
  aio: add .io_poll_begin/end() callbacks
  virtio: disable virtqueue notifications during polling

 aio-posix.c                 | 197 +++++++++++++++++++++++++++++++++++++++++++-
 async.c                     |  14 +++-
 block/curl.c                |   8 +-
 block/iscsi.c               |   3 +-
 block/linux-aio.c           |  19 ++++-
 block/nbd-client.c          |   8 +-
 block/nfs.c                 |   7 +-
 block/sheepdog.c            |  26 +++---
 block/ssh.c                 |   4 +-
 block/win32-aio.c           |   4 +-
 hw/block/virtio-blk.c       |  18 ++--
 hw/scsi/virtio-scsi.c       |  36 ++++----
 hw/virtio/virtio.c          |  60 ++++++++++++--
 include/block/aio.h         |  28 ++++++-
 iohandler.c                 |   2 +-
 nbd/server.c                |   9 +-
 stubs/set-fd-handler.c      |   1 +
 tests/test-aio.c            |   4 +-
 trace-events                |   4 +
 util/event_notifier-posix.c |   2 +-
 20 files changed, 378 insertions(+), 76 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]