qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] xen: slightly simplify bufioreq handling


From: Jan Beulich
Subject: Re: [Qemu-devel] [PATCH 2/3] xen: slightly simplify bufioreq handling
Date: Thu, 24 Nov 2016 03:31:03 -0700

>>> On 23.11.16 at 19:13, <address@hidden> wrote:
> On Wed, 23 Nov 2016, Jan Beulich wrote:
>> There's no point setting fields always receiving the same value on each
>> iteration, as handle_ioreq() doesn't alter them anyway. Set state and
>> count once ahead of the loop, drop the redundant clearing of
>> data_is_ptr, and avoid the meaningless setting of df altogether.
> 
> Why setting df is meaningless?

With count being fixed to one there's no need to update addresses,
and hence no use for knowing which direction the updates should go.

Jan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]