qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 4/5] target-m68k: Implement bitfield ops for

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 4/5] target-m68k: Implement bitfield ops for registers
Date: Mon, 28 Nov 2016 06:55:46 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 
On 11/27/2016 11:46 AM, Laurent Vivier wrote:
>> +            uint32_t maski = -2U << (len - 1);
>> > +            uint32_t roti = (ofs + len) & 31;
>> > +            tcg_gen_andi_i32(tmp, src, maski);
> should be:
> 
>                tcg_gen_andi_i32(tmp, src, ~maski);
> 
> Is it correct?

Yes.


r~
reply via email to
[Prev in Thread] Current Thread [Next in Thread]