Re: [Qemu-devel] [PATCH v2 5/9] quorum: Inline quorum_aio_cb()

[Alberto Garcia]

On Tue 29 Nov 2016 10:39:12 AM CET, Paolo Bonzini wrote:
> On 22/11/2016 13:24, Kevin Wolf wrote:
>> +
>> +    assert(rewrite == !!acb->rewrite_count);
>
> I think this might actually trigger if none of the rewrite coroutines
> yields.

I think you're right. Good catch, Paolo. Actually in the new code
'rewrite' doesn't have any purpose; it was previously needed to decide
whether to call quorum_aio_finalize() at the end of quorum_aio_cb(), but
this is not necessary now.

Berto