[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/7] 9p: v9fs fix ifnullfree.cocci warnings
From: |
edward . shishkin |
Subject: |
[Qemu-devel] [PATCH 3/7] 9p: v9fs fix ifnullfree.cocci warnings |
Date: |
Mon, 12 Dec 2016 19:15:38 +0100 |
From: kbuild test robot <address@hidden>
fs/9p/v9fs.c:318:2-7: WARNING: NULL check before freeing functions like kfree,
debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe
consider reorganizing relevant code to avoid passing NULL values.
fs/9p/v9fs.c:320:2-7: WARNING: NULL check before freeing functions like kfree,
debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe
consider reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
Signed-off-by: Fengguang Wu <address@hidden>
Signed-off-by: Eduard Shishkin <address@hidden>
---
fs/9p/v9fs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
index 3b49daf..e2f84a6 100644
--- a/fs/9p/v9fs.c
+++ b/fs/9p/v9fs.c
@@ -314,10 +314,8 @@ void put_flush_set(struct v9fs_flush_set *fset)
{
if (!fset)
return;
- if (fset->pages)
- kfree(fset->pages);
- if (fset->buf)
- kfree(fset->buf);
+ kfree(fset->pages);
+ kfree(fset->buf);
kfree(fset);
}
--
2.7.4
- [Qemu-devel] [RFC][PATCH 0/7] 9p: v9fs read and write speedup - V2, Edward Shishkin, 2016/12/12
- [Qemu-devel] [PATCH 1/7] 9p: v9fs add writepages., edward . shishkin, 2016/12/12
- [Qemu-devel] [PATCH 5/7] 9p: v9fs fix semicolon.cocci warnings, edward . shishkin, 2016/12/12
- [Qemu-devel] [PATCH 6/7] 9p: v9fs fix readpages writepages contexts allocation, edward . shishkin, 2016/12/12
- [Qemu-devel] [PATCH 7/7] 9p: v9fs fix calculation of max number of merged pages, edward . shishkin, 2016/12/12
- [Qemu-devel] [PATCH 3/7] 9p: v9fs fix ifnullfree.cocci warnings,
edward . shishkin <=
- [Qemu-devel] [PATCH 4/7] 9p: v9fs fix odd_ptr_err.cocci warnings, edward . shishkin, 2016/12/12
- [Qemu-devel] [PATCH 2/7] 9p: v9fs new readpages., edward . shishkin, 2016/12/12