[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.9 V3 1/3] Migration: Don't load vmdesc whe

From: Zhang Chen
Subject: Re: [Qemu-devel] [PATCH for-2.9 V3 1/3] Migration: Don't load vmdesc when xen is enabled
Date: Thu, 15 Dec 2016 14:46:09 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 12/14/2016 09:00 AM, Stefano Stabellini wrote:
On Fri, 9 Dec 2016, Zhang Chen wrote:
Xen doesn't need this.
Could you please elaborate a bit more on what is the problem exactly,
and why we don't have any issues with migration with Xen today (COLO
use-case aside)?

I test COLO without this patch, it seems run normally.
And I review the codes not find why we need this too.
So, I cc the original author wency about this.

CC. wency.

Zhang Chen

Signed-off-by: Zhang Chen <address@hidden>
  migration/savevm.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/migration/savevm.c b/migration/savevm.c
index 0363372..bec6c7e 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1973,6 +1973,10 @@ int qemu_loadvm_state(QEMUFile *f)
          ret = qemu_file_get_error(f);
+ if (xen_enabled()) {
+        return ret;
+    }
       * Try to read in the VMDESC section as well, so that dumping tools that
       * intercept our migration stream have the chance to see it.


Zhang Chen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]