qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 00/37] Implementation of vhost-pci for inter-


From: no-reply
Subject: Re: [Qemu-devel] [PATCH v1 00/37] Implementation of vhost-pci for inter-vm commucation
Date: Sat, 17 Dec 2016 03:38:58 -0800 (PST)

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v1 00/37] Implementation of vhost-pci for inter-vm 
commucation
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
b0804ed vl: enable vhost-pci-slave
6817843 vhost-user/msg: handling VHOST_USER_SET_FEATURES
5625ffb vhost-pci-net: start the vhost-pci-net device
a234ebe vhost-pci-slave: add "peer_reset"
2de6ab3 vhost-pci-net: send the negotiated feature bits to the master
4d698f6 vhost-user: add asynchronous read for the vhost-user master
25162f6 vhost-user/msg: send VHOST_USER_SET_VHOST_PCI (start/stop)
bafef20 vhost-pci-slave/msg: VHOST_USER_SET_VHOST_PCI (stop)
7d9fcd4 vhost-pci-slave/msg: VHOST_USER_SET_VHOST_PCI (start)
e037343 vhost-pci-net: pass the mem and vring info to the driver
9518b5d vhost-pci-net: pass the info collected by vp_slave to the device
99b1f40 vhost-pci-slave/msg: VHOST_USER_GET_VRING_BASE
976ac97 vhost-pci-slave/msg: VHOST_USER_SEND_RARP
683f514 vhost-pci-slave/msg: VHOST_USER_SET_LOG_FD
ec7ff39 vhost-pci-slave/msg: VHOST_USER_SET_LOG_BASE
597e3d1 vhost-pci-slave/msg: VHOST_USER_SET_VRING_ENABLE
96d8ed7 vhost-pci-slave/msg: VHOST_USER_SET_VRING_CALL
7bea32f vhost-pci-slave/msg: VHOST_USER_SET_VRING_KICK
78e4d19 vhost-pci-slave/msg: VHOST_USER_SET_VRING_ADDR
cad137a vhost-user: send guest physical address of virtqueues to the slave
06ca090 vhost-pci-slave/msg: VHOST_USER_SET_VRING_BASE
450f521 vhost-pci-slave/msg: VHOST_USER_SET_VRING_NUM
396bda9 vhost-pci-slave/msg: VHOST_USER_SET_MEM_TABLE
9b22d68 vhost-pci-slave/msg: VHOST_USER_SET_OWNER
c8f6463 vhost-pci-slave/msg: VHOST_USER_GET_QUEUE_NUM
2971089 vhost-pci-slave/msg: VHOST_USER_SET_DEVICE_ID
ad3e6ee vhost-user/msg: VHOST_USER_PROTOCOL_F_SET_DEVICE_ID
c1cd46a vhost-pci-slave/msg: VHOST_USER_SET_PROTOCOL_FEATURES
ec6ae04 vhost-pci-slave/msg: VHOST_USER_GET_PROTOCOL_FEATURES
35242dd vhost-pci-slave/msg: VHOST_USER_SET_FEATURES
ddda2fb vhost-pci-slave/msg: VHOST_USER_GET_FEATURES
b168748 vhost-pci-slave: set up the fundamental handlers for the server socket
9eaf436 vhost-pci-slave: start the implementation of vhost-pci-slave
798c50f vl: add the vhost-pci-slave command line option
2b7ed80 vhost-user: share the vhost-user protocol related structures
6b83939 vhost-pci-net: the fundamental implementation of vhost-pci-net-pci
94d5a87 vhost-pci-net: the fundamental vhost-pci-net device emulation

=== OUTPUT BEGIN ===
Checking PATCH 1/37: vhost-pci-net: the fundamental vhost-pci-net device 
emulation...
WARNING: line over 80 characters
#64: FILE: hw/net/vhost-pci-net.c:35:
+static uint64_t vpnet_get_features(VirtIODevice *vdev, uint64_t features, 
Error **errp)

ERROR: space required after that ',' (ctx:VxV)
#103: FILE: hw/net/vhost-pci-net.c:74:
+        vpnet->rqs[i] = virtio_add_queue(vdev,VPNET_RQ_SIZE,
                                              ^

ERROR: braces {} are necessary even for single statement blocks
#115: FILE: hw/net/vhost-pci-net.c:86:
+    for (i = 0; i < rq_num + 2; i++)
+        virtio_del_queue(vdev, i);

total: 2 errors, 1 warnings, 256 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/37: vhost-pci-net: the fundamental implementation of 
vhost-pci-net-pci...
Checking PATCH 3/37: vhost-user: share the vhost-user protocol related 
structures...
ERROR: spaces required around that '<<' (ctx:VxV)
#189: FILE: include/hw/virtio/vhost-user.h:66:
+#define VHOST_USER_REPLY_MASK       (0x1<<2)
                                         ^

ERROR: spaces required around that '<<' (ctx:VxV)
#195: FILE: include/hw/virtio/vhost-user.h:72:
+#define VHOST_USER_VRING_NOFD_MASK  (0x1<<8)
                                         ^

total: 2 errors, 0 warnings, 200 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/37: vl: add the vhost-pci-slave command line option...
ERROR: line over 90 characters
#67: FILE: vl.c:4063:
+                opts = 
qemu_opts_parse_noisily(qemu_find_opts("vhost-pci-slave"), optarg, false);

total: 1 errors, 0 warnings, 49 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/37: vhost-pci-slave: start the implementation of 
vhost-pci-slave...
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 
2459.
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 
2459.
Use of uninitialized value $1 in concatenation (.) or string at 
./scripts/checkpatch.pl line 2460.
ERROR: unnecessary cast may hide bugs, use g_new instead
#66: FILE: hw/virtio/vhost-pci-slave.c:37:
+    vp_slave = (VhostPCISlave *)g_malloc(sizeof(VhostPCISlave));

total: 1 errors, 0 warnings, 76 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/37: vhost-pci-slave: set up the fundamental handlers for the 
server socket...
ERROR: braces {} are necessary for all arms of this statement
#60: FILE: hw/virtio/vhost-pci-slave.c:60:
+    if (msg.request > VHOST_USER_MAX)
[...]

ERROR: space required before the open parenthesis '('
#63: FILE: hw/virtio/vhost-pci-slave.c:63:
+    switch(msg.request) {

total: 2 errors, 0 warnings, 68 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/37: vhost-pci-slave/msg: VHOST_USER_GET_FEATURES...
ERROR: Macros with complex values should be enclosed in parenthesis
#26: FILE: hw/virtio/vhost-pci-slave.c:23:
+#define VHOST_PCI_NET_FEATURE_BITS (1ULL << VIRTIO_NET_F_MRG_RXBUF) | \
+                                   (1ULL << VIRTIO_NET_F_CTRL_VQ) | \
+                                   (1ULL << VIRTIO_NET_F_MQ)

ERROR: braces {} are necessary for all arms of this statement
#36: FILE: hw/virtio/vhost-pci-slave.c:33:
+    if (!msg)
[...]

ERROR: braces {} are necessary for all arms of this statement
#73: FILE: hw/virtio/vhost-pci-slave.c:98:
+        if (ret < 0)
[...]

total: 3 errors, 0 warnings, 83 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 8/37: vhost-pci-slave/msg: VHOST_USER_SET_FEATURES...
Checking PATCH 9/37: vhost-pci-slave/msg: VHOST_USER_GET_PROTOCOL_FEATURES...
WARNING: line over 80 characters
#21: FILE: hw/virtio/vhost-pci-slave.c:70:
+static int vp_slave_get_protocol_features(CharBackend *chr_be, VhostUserMsg 
*msg)

ERROR: braces {} are necessary for all arms of this statement
#39: FILE: hw/virtio/vhost-pci-slave.c:122:
+        if (ret < 0)
[...]

ERROR: spaces required around that '=' (ctx:WxV)
#53: FILE: include/hw/virtio/vhost-user.h:14:
+    VHOST_USER_PROTOCOL_F_VHOST_PCI =4,
                                     ^

ERROR: Macros with complex values should be enclosed in parenthesis
#60: FILE: include/hw/virtio/vhost-user.h:21:
+#define VHOST_USER_PROTOCOL_FEATURES ((1ULL << VHOST_USER_PROTOCOL_F_MQ) | \
+                                      (1ULL << 
VHOST_USER_PROTOCOL_F_LOG_SHMFD) | \
+                                      (1ULL << VHOST_USER_PROTOCOL_F_RARP)) | \
+                                      (1ULL << VHOST_USER_PROTOCOL_F_VHOST_PCI)

WARNING: line over 80 characters
#61: FILE: include/hw/virtio/vhost-user.h:22:
+                                      (1ULL << 
VHOST_USER_PROTOCOL_F_LOG_SHMFD) | \

total: 3 errors, 2 warnings, 44 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/37: vhost-pci-slave/msg: VHOST_USER_SET_PROTOCOL_FEATURES...
Checking PATCH 11/37: vhost-user/msg: VHOST_USER_PROTOCOL_F_SET_DEVICE_ID...
WARNING: line over 80 characters
#54: FILE: hw/virtio/vhost-user.c:524:
+        if (dev->protocol_features & (1ULL << 
VHOST_USER_PROTOCOL_F_SET_DEVICE_ID)) {

WARNING: line over 80 characters
#81: FILE: include/hw/virtio/vhost-user.h:25:
+                                      (1ULL << 
VHOST_USER_PROTOCOL_F_VHOST_PCI) | \

WARNING: line over 80 characters
#82: FILE: include/hw/virtio/vhost-user.h:26:
+                                      (1ULL << 
VHOST_USER_PROTOCOL_F_SET_DEVICE_ID)

total: 0 errors, 3 warnings, 68 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/37: vhost-pci-slave/msg: VHOST_USER_SET_DEVICE_ID...
Checking PATCH 13/37: vhost-pci-slave/msg: VHOST_USER_GET_QUEUE_NUM...
ERROR: braces {} are necessary for all arms of this statement
#46: FILE: hw/virtio/vhost-pci-slave.c:163:
+        if (ret < 0)
[...]

total: 1 errors, 0 warnings, 34 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 14/37: vhost-pci-slave/msg: VHOST_USER_SET_OWNER...
Checking PATCH 15/37: vhost-pci-slave/msg: VHOST_USER_SET_MEM_TABLE...
ERROR: braces {} are necessary for all arms of this statement
#35: FILE: hw/virtio/vhost-pci-slave.c:37:
+        if (ret < 0)
[...]

ERROR: spaces required around that '+' (ctx:VxV)
#37: FILE: hw/virtio/vhost-pci-slave.c:39:
+        memory_region_del_subregion(vp_slave->bar_mr, vp_slave->sub_mr+i);
                                                                       ^

ERROR: braces {} are necessary for all arms of this statement
#74: FILE: hw/virtio/vhost-pci-slave.c:150:
+    if (fd_num != nregions)
[...]

ERROR: braces {} are necessary for all arms of this statement
#77: FILE: hw/virtio/vhost-pci-slave.c:153:
+    if (vp_slave->bar_mr == NULL)
[...]

ERROR: braces {} are necessary for all arms of this statement
#79: FILE: hw/virtio/vhost-pci-slave.c:155:
+    if (vp_slave->sub_mr == NULL)
[...]

total: 5 errors, 0 warnings, 165 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 16/37: vhost-pci-slave/msg: VHOST_USER_SET_VRING_NUM...
Checking PATCH 17/37: vhost-pci-slave/msg: VHOST_USER_SET_VRING_BASE...
Checking PATCH 18/37: vhost-user: send guest physical address of virtqueues to 
the slave...
WARNING: line over 80 characters
#103: FILE: hw/virtio/vhost.c:1028:
+        cpu_physical_memory_unmap(vq->used, virtio_queue_get_used_size(vdev, 
idx),

WARNING: line over 80 characters
#105: FILE: hw/virtio/vhost.c:1030:
+        cpu_physical_memory_unmap(vq->avail, virtio_queue_get_avail_size(vdev, 
idx),

WARNING: line over 80 characters
#107: FILE: hw/virtio/vhost.c:1032:
+        cpu_physical_memory_unmap(vq->desc, virtio_queue_get_desc_size(vdev, 
idx),

total: 0 errors, 3 warnings, 98 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 19/37: vhost-pci-slave/msg: VHOST_USER_SET_VRING_ADDR...
Checking PATCH 20/37: vhost-pci-slave/msg: VHOST_USER_SET_VRING_KICK...
Checking PATCH 21/37: vhost-pci-slave/msg: VHOST_USER_SET_VRING_CALL...
Checking PATCH 22/37: vhost-pci-slave/msg: VHOST_USER_SET_VRING_ENABLE...
Checking PATCH 23/37: vhost-pci-slave/msg: VHOST_USER_SET_LOG_BASE...
Checking PATCH 24/37: vhost-pci-slave/msg: VHOST_USER_SET_LOG_FD...
Checking PATCH 25/37: vhost-pci-slave/msg: VHOST_USER_SEND_RARP...
Checking PATCH 26/37: vhost-pci-slave/msg: VHOST_USER_GET_VRING_BASE...
ERROR: braces {} are necessary for all arms of this statement
#36: FILE: hw/virtio/vhost-pci-slave.c:334:
+        if (ret < 0)
[...]

total: 1 errors, 0 warnings, 27 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 27/37: vhost-pci-net: pass the info collected by vp_slave to the 
device...
ERROR: braces {} are necessary for all arms of this statement
#37: FILE: hw/net/vhost-pci-net.c:38:
+    if (vpnet->pvq_msg == NULL)
[...]

WARNING: line over 80 characters
#38: FILE: hw/net/vhost-pci-net.c:39:
+        vpnet->pvq_msg = g_malloc0(sizeof(struct peer_vq_msg) * (vring_num + 
1));

total: 1 errors, 1 warnings, 93 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 28/37: vhost-pci-net: pass the mem and vring info to the 
driver...
Checking PATCH 29/37: vhost-pci-slave/msg: VHOST_USER_SET_VHOST_PCI (start)...
ERROR: braces {} are necessary for all arms of this statement
#66: FILE: hw/virtio/vhost-pci-slave.c:298:
+        if (ret < 0)
[...]

ERROR: braces {} are necessary for all arms of this statement
#86: FILE: hw/virtio/vhost-pci-slave.c:421:
+        if (ret < 0)
[...]

total: 2 errors, 0 warnings, 86 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 30/37: vhost-pci-slave/msg: VHOST_USER_SET_VHOST_PCI (stop)...
ERROR: braces {} are necessary for all arms of this statement
#37: FILE: hw/virtio/vhost-pci-slave.c:37:
+    if (!vp_slave->vdev)
[...]

total: 1 errors, 0 warnings, 85 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 31/37: vhost-user/msg: send VHOST_USER_SET_VHOST_PCI 
(start/stop)...
ERROR: spaces required around that '-' (ctx:VxV)
#35: FILE: hw/net/vhost_net.c:343:
+    last_net = get_vhost_net(ncs[total_queues-1].peer);
                                              ^

ERROR: spaces required around that '-' (ctx:VxV)
#37: FILE: hw/net/vhost_net.c:345:
+        r = vhost_set_vhost_pci(ncs[total_queues-1].peer,
                                                 ^

ERROR: braces {} are necessary for all arms of this statement
#39: FILE: hw/net/vhost_net.c:347:
+        if (r < 0)
[...]

ERROR: spaces required around that '-' (ctx:VxV)
#53: FILE: hw/net/vhost_net.c:375:
+    last_net = get_vhost_net(ncs[total_queues-1].peer);
                                              ^

ERROR: braces {} are necessary for all arms of this statement
#54: FILE: hw/net/vhost_net.c:376:
+    if (vhost_pci_enabled(&last_net->dev))
[...]

ERROR: spaces required around that '-' (ctx:VxV)
#55: FILE: hw/net/vhost_net.c:377:
+        vhost_set_vhost_pci(ncs[total_queues-1].peer,
                                             ^

total: 6 errors, 0 warnings, 119 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 32/37: vhost-user: add asynchronous read for the vhost-user 
master...
ERROR: Error messages should not contain newlines
#42: FILE: hw/virtio/vhost-user.c:91:
+        error_report("Wrong message size received %d\n", size);

ERROR: Error messages should not contain newlines
#52: FILE: hw/virtio/vhost-user.c:101:
+            error_report("Wrong message size received %d != %d\n",

ERROR: braces {} are necessary for all arms of this statement
#58: FILE: hw/virtio/vhost-user.c:107:
+    if (msg.request > VHOST_USER_MAX)
[...]

ERROR: unnecessary whitespace before a quoted newline
#59: FILE: hw/virtio/vhost-user.c:108:
+        error_report("vhost-user master read incorrect msg \n");

ERROR: Error messages should not contain newlines
#59: FILE: hw/virtio/vhost-user.c:108:
+        error_report("vhost-user master read incorrect msg \n");

ERROR: space required before the open parenthesis '('
#61: FILE: hw/virtio/vhost-user.c:110:
+    switch(msg.request) {

ERROR: Error messages should not contain newlines
#63: FILE: hw/virtio/vhost-user.c:112:
+        error_report("vhost-user master does not support msg request = %d\n",

WARNING: line over 80 characters
#143: FILE: net/vhost-user.c:284:
+        qemu_chr_fe_set_handlers(&s->chr, vhost_user_can_read, 
vhost_user_asyn_read,

total: 7 errors, 1 warnings, 112 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 33/37: vhost-pci-net: send the negotiated feature bits to the 
master...
ERROR: braces {} are necessary for all arms of this statement
#35: FILE: hw/net/vhost-pci-net.c:146:
+        if (ret < 0)
[...]

total: 1 errors, 0 warnings, 57 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 34/37: vhost-pci-slave: add "peer_reset"...
ERROR: braces {} are necessary for all arms of this statement
#43: FILE: hw/virtio/vhost-pci-slave.c:44:
+    if (!vp_slave->peer_reset)
[...]

ERROR: braces {} are necessary for all arms of this statement
#57: FILE: hw/virtio/vhost-pci-slave.c:175:
+        if (!vp_slave->peer_reset)
[...]

ERROR: braces {} are necessary for all arms of this statement
#67: FILE: hw/virtio/vhost-pci-slave.c:364:
+        if (vp_slave->peer_reset)
[...]

total: 3 errors, 0 warnings, 58 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 35/37: vhost-pci-net: start the vhost-pci-net device...
Checking PATCH 36/37: vhost-user/msg: handling VHOST_USER_SET_FEATURES...
ERROR: unnecessary whitespace before a quoted newline
#60: FILE: hw/virtio/vhost-user.c:124:
         error_report("vhost-user master read incorrect msg \n");

total: 1 errors, 0 warnings, 133 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 37/37: vl: enable vhost-pci-slave...
ERROR: braces {} are necessary for all arms of this statement
#63: FILE: vl.c:4729:
+        if (ret < 0)
[...]

total: 1 errors, 0 warnings, 50 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]