[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilitie
From: |
P J P |
Subject: |
Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size |
Date: |
Tue, 20 Dec 2016 17:26:16 +0530 (IST) |
Hello Marc,
+-- On Tue, 20 Dec 2016, Marc-André Lureau wrote --+
| > + if (!max_size) {
|
| Shouldn't it check for >= sizeof(union virgl_caps) ? (since that's what
| virglrenderer vrend_renderer_fill_caps() expects)
No, 'max_size' isn't set by a user, it's set by the library function
'vrend_renderer_get_cap_set'.
->
https://cgit.freedesktop.org/~airlied/virglrenderer/tree/src/vrend_renderer.c#n6280
And if not zero, it'll be set to sizeof(union virgl_caps).
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
- Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size, (continued)
[Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size, P J P, 2016/12/14