[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] ipmi: Fix macro issues
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2] ipmi: Fix macro issues |
Date: |
Thu, 22 Dec 2016 16:17:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 12/22/2016 01:18 PM, address@hidden wrote:
> From: Corey Minyard <address@hidden>
>
> Macro parameters should almost always have () around them when used.
> llvm reported an error on this.
>
> Remove redundant parenthesis and put parenthesis around the entire
> macros with assignments in case they are used in an expression.
>
> Remove some unused macros.
>
> Reported in https://bugs.launchpad.net/bugs/1651167
>
> Signed-off-by: Corey Minyard <address@hidden>
> ---
> hw/ipmi/isa_ipmi_bt.c | 34 ++++++++++++----------------------
> 1 file changed, 12 insertions(+), 22 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [Bug 1651167] [NEW] hw/ipmi/isa_ipmi_bt.c:283: suspect use of macro ?, dcb, 2016/12/19
- Re: [Qemu-devel] [Bug 1651167] [NEW] hw/ipmi/isa_ipmi_bt.c:283: suspect use of macro ?, Corey Minyard, 2016/12/22
- [Qemu-devel] [Bug 1651167] Re: hw/ipmi/isa_ipmi_bt.c:283: suspect use of macro ?, cminyard, 2016/12/22
- [Qemu-devel] [PATCH] ipmi: Add parenthesis around some macro parameters, minyard, 2016/12/22
- [Qemu-devel] [PATCH v2] ipmi: Fix macro issues, minyard, 2016/12/22
- Re: [Qemu-devel] [PATCH v2] ipmi: Fix macro issues,
Eric Blake <=
- [Qemu-devel] [PATCH v3] ipmi: Fix macro issues, minyard, 2016/12/23