[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/8] io: add ability to associate an opaque "res
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/8] io: add ability to associate an opaque "result" with with a task |
Date: |
Thu, 5 Jan 2017 14:32:46 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 01/05/2017 10:03 AM, Daniel P. Berrange wrote:
> Currently there is no data associated with a successful
> task completion. This adds an opaque pointer to the task
> to store an arbitrary result.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> include/io/task.h | 27 +++++++++++++++++++++++++++
> io/task.c | 20 ++++++++++++++++++++
> 2 files changed, 47 insertions(+)
>
I suppose a different approach would have been changing QIOTaskFunc() to
have a void* return, but that would be more invasive. Grabbing the
result separately from the task completing is a bit weird, but looks
like it will work.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/8] io: enable DNS resolving separately of socket create, Daniel P. Berrange, 2017/01/05
- [Qemu-devel] [PATCH 2/8] io: stop incrementing reference in qio_task_get_source, Daniel P. Berrange, 2017/01/05
- [Qemu-devel] [PATCH 3/8] io: fix typo in docs for QIOTask, Daniel P. Berrange, 2017/01/05
- [Qemu-devel] [PATCH 1/8] sockets: add ability to disable DNS resolution for InetSocketAddress, Daniel P. Berrange, 2017/01/05
- [Qemu-devel] [PATCH 4/8] io: add ability to associate an opaque "result" with with a task, Daniel P. Berrange, 2017/01/05
- Re: [Qemu-devel] [PATCH 4/8] io: add ability to associate an opaque "result" with with a task,
Eric Blake <=
- [Qemu-devel] [PATCH 5/8] io: add ability to associate an error with a task, Daniel P. Berrange, 2017/01/05
- [Qemu-devel] [PATCH 6/8] io: change the QIOTask callback signature, Daniel P. Berrange, 2017/01/05
- [Qemu-devel] [PATCH 8/8] io: introduce a DNS resolver API, Daniel P. Berrange, 2017/01/05