[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/20] tests: fix linking test-char on win32

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 01/20] tests: fix linking test-char on win32
Date: Fri, 6 Jan 2017 10:45:14 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/05/2017 10:53 AM, Marc-André Lureau wrote:
> test-char.exe needs main-loop.o symbols, among others. Linking with
> $(test-block-obj-y) brings what's necessary. We could try to eventually
> strip to the minimum if needed.
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  tests/Makefile.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Can I have a bit more background? I'm guessing this doesn't fix an
actual failure at the moment (probably due to one of the other files
dragging in stuff indirectly), but rather cleans up a latent problem
that would otherwise be exposed with patches later in the series (where
splitting files means the stuff is no longer dragged in indirectly, so
we need to mention it explicitly)?

Even mentioning _which_ main-loop.o symbol to be grepping for in
test-char.c might be helpful to the review.

> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 4841d582a1..a8f3d12e49 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -489,7 +489,7 @@ tests/check-qjson$(EXESUF): tests/check-qjson.o 
> $(test-util-obj-y)
>  tests/check-qom-interface$(EXESUF): tests/check-qom-interface.o 
> $(test-qom-obj-y)
>  tests/check-qom-proplist$(EXESUF): tests/check-qom-proplist.o 
> $(test-qom-obj-y)
> -tests/test-char$(EXESUF): tests/test-char.o qemu-char.o qemu-timer.o 
> $(test-util-obj-y) $(qtest-obj-y) $(test-io-obj-y)
> +tests/test-char$(EXESUF): tests/test-char.o qemu-char.o qemu-timer.o 
> $(test-util-obj-y) $(qtest-obj-y) $(test-block-obj-y)

At any rate, test-block-obj-y is simply test-io-obj-y plus the
additional block-obj-y, so you're merely adding an additional dependency
on block-obj-y files.  While a nicer commit message may help, I don't
see any technical problem in the change, so here's a weak:

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]