[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 40/47] trace: switch target/s390x/ directory

From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH v2 40/47] trace: switch target/s390x/ directory to modular trace.h file
Date: Fri, 6 Jan 2017 17:18:13 +0000
User-agent: Mutt/1.7.1 (2016-10-04)

On Fri, Jan 06, 2017 at 06:09:16PM +0100, Lluís Vilanova wrote:
> Daniel P Berrange writes:
> > Switch files in the target/s390x/ directory to include the
> > target/s390x/trace.h file instead of the global trace.h
> > file.
> > The make rules for gen-features.{h,c} need to be moved
> > out into the top level Makefile.objs, otherwise make
> > complains about the rules being defined multiple times
> > due to target/s390x/Makefile.objs being included
> > multiple times when expanding different subdir object
> > lists.
> If the problem is re-definition, you can instead add a guard around the rules 
> in
> target/s390x/Makefile.objs. This avoids defining the rules multiple times but
> still keeps the target-specific rules in the target-specific makefile.

What kind of guard to you mean ? What's happening is that the top
level Makefile.target is including target/s390x/Makefile.objs
multiple times to expand multiple vars. I don't see a way to
distinguish which include we're being called from.

|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

reply via email to

[Prev in Thread] Current Thread [Next in Thread]