[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 47/47] trace: improve error reporting when pa

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 47/47] trace: improve error reporting when parsing simpletrace header
Date: Fri, 6 Jan 2017 12:15:37 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/06/2017 09:55 AM, Daniel P. Berrange wrote:
> When loading a simpletrace binary file we just report
> "Not a valid trace file!" which is not very helpful. Report
> exactly which field we found to be invalid.
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  scripts/simpletrace.py | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

Could be applied independently, so:

Reviewed-by: Eric Blake <address@hidden>

I'll leave a review of the Makefile magic in 1/47 to someone more
comfortable with it, but if that gets approved, you are right that most
of this series is pretty boring and mechanical.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]