[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/20] char: allocate CharDriverState as a singl

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 11/20] char: allocate CharDriverState as a single object
Date: Fri, 6 Jan 2017 15:43:11 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/05/2017 10:53 AM, Marc-André Lureau wrote:
> Use a single allocation for CharDriverState, this avoids extra
> allocations & pointers, and is a step towards more object-oriented
> CharDriver.
> Gtk console is a bit peculiar, gd_vc_chr_set_echo() used to have a
> temporary VirtualConsole to save the echo bit. Instead now, we consider
> whether vcd->console is set or not, and restore the echo bit saved in
> VCDriverState when calling gd_vc_vte_init().
> The casts added are temporary, they are replaced with QOM type-safe
> macros in a later patch in this series.

Thanks; that commit message addition helps.

> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

R-b stands.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]