[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 07/11] gtk: avoid oob array access
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL v2 07/11] gtk: avoid oob array access |
Date: |
Mon, 9 Jan 2017 14:09:41 +0100 |
From: Marc-André Lureau <address@hidden>
When too many consoles are created, vcs[] may be write out-of-bounds.
Signed-off-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/gtk.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index 356f400..86368e3 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1706,6 +1706,11 @@ static CharDriverState *gd_vc_handler(ChardevVC *vc,
Error **errp)
ChardevCommon *common = qapi_ChardevVC_base(vc);
CharDriverState *chr;
+ if (nb_vcs == MAX_VCS) {
+ error_setg(errp, "Maximum number of consoles reached");
+ return NULL;
+ }
+
chr = qemu_chr_alloc(common, errp);
if (!chr) {
return NULL;
--
1.8.3.1
- [Qemu-devel] [PULL v2 00/11] ui patch queue, Gerd Hoffmann, 2017/01/09
- [Qemu-devel] [PULL v2 03/11] console: add API to get underlying gui window ID, Gerd Hoffmann, 2017/01/09
- [Qemu-devel] [PULL v2 01/11] ui/gtk: fix crash at startup when no console is available, Gerd Hoffmann, 2017/01/09
- [Qemu-devel] [PULL v2 08/11] ui: drop unused MOUSE_EVENT_WHEEL{UP, DN} defines, Gerd Hoffmann, 2017/01/09
- [Qemu-devel] [PULL v2 10/11] curses: Fix compiler warnings (Mingw-w64 redefinition of macro KEY_EVENT), Gerd Hoffmann, 2017/01/09
- [Qemu-devel] [PULL v2 02/11] ui: use evdev keymap when running under wayland, Gerd Hoffmann, 2017/01/09
- [Qemu-devel] [PULL v2 07/11] gtk: avoid oob array access,
Gerd Hoffmann <=
- [Qemu-devel] [PULL v2 06/11] egl-helpers: Change file licensing to LGPLv2, Gerd Hoffmann, 2017/01/09
- [Qemu-devel] [PULL v2 11/11] ps2: Fix lost scancodes by recent changes, Gerd Hoffmann, 2017/01/09
- [Qemu-devel] [PULL v2 04/11] console: move window ID code from baum to sdl, Gerd Hoffmann, 2017/01/09
- [Qemu-devel] [PULL v2 05/11] sdl2: set window ID, Gerd Hoffmann, 2017/01/09
[Qemu-devel] [PULL v2 09/11] ui/vnc: Fix problem with sending too many bytes as server name, Gerd Hoffmann, 2017/01/09
Re: [Qemu-devel] [PULL v2 00/11] ui patch queue, Peter Maydell, 2017/01/09