Re: [Qemu-devel] [PATCH] hw/net: implement MIB counters in mcf_fec driver

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] hw/net: implement MIB counters in mcf_fec driver

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
8b594c1 hw/net: implement MIB counters in mcf_fec driver

=== OUTPUT BEGIN ===
Checking PATCH 1/1: hw/net: implement MIB counters in mcf_fec driver...
ERROR: braces {} are necessary for all arms of this statement
#120: FILE: hw/net/mcf_fec.c:211:
+    if (size < 64)
[...]
+    else if (size == 64)
[...]
+    else if (size < 128)
[...]
+    else if (size < 256)
[...]
+    else if (size < 512)
[...]
+    else if (size < 1024)
[...]
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#122: FILE: hw/net/mcf_fec.c:213:
+    else if (size == 64)
[...]
+    else if (size < 128)
[...]
+    else if (size < 256)
[...]
+    else if (size < 512)
[...]
+    else if (size < 1024)
[...]
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#124: FILE: hw/net/mcf_fec.c:215:
+    else if (size < 128)
[...]
+    else if (size < 256)
[...]
+    else if (size < 512)
[...]
+    else if (size < 1024)
[...]
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#126: FILE: hw/net/mcf_fec.c:217:
+    else if (size < 256)
[...]
+    else if (size < 512)
[...]
+    else if (size < 1024)
[...]
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#128: FILE: hw/net/mcf_fec.c:219:
+    else if (size < 512)
[...]
+    else if (size < 1024)
[...]
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#130: FILE: hw/net/mcf_fec.c:221:
+    else if (size < 1024)
[...]
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#132: FILE: hw/net/mcf_fec.c:223:
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#176: FILE: hw/net/mcf_fec.c:496:
+    if (size < 64)
[...]
+    else if (size == 64)
[...]
+    else if (size < 128)
[...]
+    else if (size < 256)
[...]
+    else if (size < 512)
[...]
+    else if (size < 1024)
[...]
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#178: FILE: hw/net/mcf_fec.c:498:
+    else if (size == 64)
[...]
+    else if (size < 128)
[...]
+    else if (size < 256)
[...]
+    else if (size < 512)
[...]
+    else if (size < 1024)
[...]
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#180: FILE: hw/net/mcf_fec.c:500:
+    else if (size < 128)
[...]
+    else if (size < 256)
[...]
+    else if (size < 512)
[...]
+    else if (size < 1024)
[...]
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#182: FILE: hw/net/mcf_fec.c:502:
+    else if (size < 256)
[...]
+    else if (size < 512)
[...]
+    else if (size < 1024)
[...]
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#184: FILE: hw/net/mcf_fec.c:504:
+    else if (size < 512)
[...]
+    else if (size < 1024)
[...]
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#186: FILE: hw/net/mcf_fec.c:506:
+    else if (size < 1024)
[...]
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: braces {} are necessary for all arms of this statement
#188: FILE: hw/net/mcf_fec.c:508:
+    else if (size < 2048)
[...]
+    else
[...]

ERROR: Missing Signed-off-by: line(s)

total: 15 errors, 0 warnings, 167 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden