[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 02/47] trace: switch io/ directory to modular

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 02/47] trace: switch io/ directory to modular trace.h file
Date: Tue, 10 Jan 2017 18:45:23 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

On 10/01/2017 17:51, Daniel P. Berrange wrote:
> It doesn't work with builddir != srcdir builds, because -I. is resolved
> to the srcdir, but the trace.h is in builddir.

This is a bug then.  The toplevel builddir (or for that matter srcdir)
is not meant to be in the search path: only the toplevel include/, the
subdirectory builddir, and the subdirectory srcdir.

> In the end I thought it would be clearer to be explicit about the
> subdir we're pulling trace.h from anyway, since it is fairly common
> practice  in QEMU to have the <subdir> in the #include filename.

Hmm, I don't think so.  The idea is that all includes are nested, so
that a local directory #include has no subdir while one from #include/
has one.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]